After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795719 - Typo in git version macro
Typo in git version macro
Status: RESOLVED INVALID
Product: shotwell
Classification: Other
Component: build
0.29.x
Other Linux
: Normal critical
: ---
Assigned To: Shotwell Maintainers
Shotwell Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-05-01 15:49 UTC by Joerg C. Frings-Fuerst
Modified: 2018-05-03 19:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch file (699 bytes, patch)
2018-05-01 15:54 UTC, Joerg C. Frings-Fuerst 		committed Details | Review

Description Joerg C. Frings-Fuerst 2018-05-01 15:49:19 UTC 
Hi,

in src/Resources.vala used _GITVERSION but in meson.build is _GIT_VERSION set.

CU
Jörg
Comment 1 Joerg C. Frings-Fuerst 2018-05-01 15:54:27 UTC 
Created attachment 371580 [details] [review]
patch file
Comment 2 Jens Georg 2018-05-02 07:36:15 UTC 
did that cause any issues? Because - I know it's confusing - the C define is _GIT_VERSION, but the vala conditional is _GITVERSION
Comment 3 Jens Georg 2018-05-02 07:37:06 UTC 
if gitver.returncode() == 0
  add_global_arguments(['-D_GIT_VERSION="@0@"'.format(gitver.stdout().strip())],
    language : 'c')
  add_global_arguments(['--define=_GITVERSION'], language : 'vala')
endif