After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795598 - search-toolbar: Search for notes after a slight delay
search-toolbar: Search for notes after a slight delay
Status: RESOLVED FIXED
Product: bijiben
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Bijiben maintainer(s)
Bijiben maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2018-04-27 09:21 UTC by Mohammed Sadiq
Modified: 2018-04-28 03:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
search-toolbar: Search for notes after a slight delay (1.39 KB, patch)
2018-04-27 09:21 UTC, Mohammed Sadiq 		committed Details | Review

Description Mohammed Sadiq 2018-04-27 09:21:30 UTC 
.
Comment 1 Mohammed Sadiq 2018-04-27 09:21:37 UTC 
Created attachment 371452 [details] [review]
search-toolbar: Search for notes after a slight delay

The "notify::text" is emitted for every change immediately. This
can make the UI freeze if there is too much to search.

Instead, we can better connect to "search-changed" signal which
gets emitted every 150ms after some text change.
Comment 2 Isaque Galdino 2018-04-28 02:55:36 UTC 
Review of attachment 371452 [details] [review]:

Seems good!
Comment 3 Mohammed Sadiq 2018-04-28 03:02:08 UTC 
Attachment 371452 [details] pushed as 907881f - search-toolbar: Search for notes after a slight delay