After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795452 - Don't print the path to meson.build when running 'jhbuild make'
Don't print the path to meson.build when running 'jhbuild make'
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: general
unspecified
Other FreeBSD
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2018-04-22 06:36 UTC by Ting-Wei Lan
Modified: 2018-04-22 16:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
make: Don't print the path to meson.build (1009 bytes, patch)
2018-04-22 06:37 UTC, Ting-Wei Lan
committed Details | Review

Description Ting-Wei Lan 2018-04-22 06:36:11 UTC
It was added in bug 794179, but the bug report doesn't explain why it was needed. It looks confusing because it is also printed when building an autotools module.
Comment 1 Ting-Wei Lan 2018-04-22 06:37:06 UTC
Created attachment 371217 [details] [review]
make: Don't print the path to meson.build

It is not needed and possibly confusing because it is also printed when
JHBuild decides to use autotools.
Comment 2 Bastien Nocera 2018-04-22 15:54:38 UTC
(In reply to Ting-Wei Lan from comment #0)
> It was added in bug 794179, but the bug report doesn't explain why it was
> needed. It looks confusing because it is also printed when building an
> autotools module.

The print wasn't needed, it's a left over from debug, to make sure it was detecting the file correctly.
Comment 3 Bastien Nocera 2018-04-22 15:55:14 UTC
Review of attachment 371217 [details] [review]:

You can rename that "Remove left-over debug". It didn't have any functional reason to exist.