After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 795109 - fakevideosink: should request an extra buffer if enable-last-sample is enabled
fakevideosink: should request an extra buffer if enable-last-sample is enabled
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.14.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-04-09 15:57 UTC by Guillaume Desmottes
Modified: 2018-04-09 16:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fakevideosink: request an extra buffer if enable-last-sample is enabled (1.93 KB, patch)
2018-04-09 15:57 UTC, Guillaume Desmottes 		accepted-commit_now Details | Review

Description Guillaume Desmottes 2018-04-09 15:57:22 UTC 
.
Comment 1 Guillaume Desmottes 2018-04-09 15:57:39 UTC 
Created attachment 370697 [details] [review]
fakevideosink: request an extra buffer if enable-last-sample is enabled

If the 'enable-last-sample' property is enabled, fakevideosink will keep
a reference on last rendered buffer which may lead to buffer starvation
in the pipeline.
Request one extra buffer in this case so we always have a buffer flying
in the pipeline.
Comment 2 Nicolas Dufresne (ndufresne) 2018-04-09 16:01:23 UTC 
Review of attachment 370697 [details] [review]:

Just a naming nitpick, you can plane that in 1.14 please.

::: gst/debugutils/gstfakevideosink.c
@@ +56,3 @@
   GstCaps *caps;
   GstVideoInfo info;
+  guint nb_buffers = 1;

-> min_buffers
Comment 3 Guillaume Desmottes 2018-04-09 16:27:15 UTC 
Fixed the variable name and pushed to master (9cd77b164433e925ee9055ac64d5599713724410) and 1.14 (e5e2eccee6e1c89d16aa5f0b86043463862dc6ae).