After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794816 - splitmuxsink: Add new reset-muxer property
splitmuxsink: Add new reset-muxer property
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal enhancement
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-03-29 16:21 UTC by Sebastian Dröge (slomo)
Modified: 2018-04-03 11:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
splitmuxsink: Add new reset-muxer property (4.76 KB, patch)
2018-03-29 16:21 UTC, Sebastian Dröge (slomo) 		committed Details | Review
mpegtsmux: Resend initial segments and header sections after FLUSH_STOP (1.25 KB, patch)
2018-03-29 16:21 UTC, Sebastian Dröge (slomo) 		committed Details | Review
hlssink2: Use the new reset-muxer property on splitmuxsink (1.15 KB, patch)
2018-03-29 16:21 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Sebastian Dröge (slomo) 2018-03-29 16:21:00 UTC 
See commit messages for explanation. This seems relatively fragile and not so
nice, but I'm not sure what a better way to implement this would be.
Comment 1 Sebastian Dröge (slomo) 2018-03-29 16:21:08 UTC 
Created attachment 370305 [details] [review]
splitmuxsink: Add new reset-muxer property

With this the muxer is not set to NULL after each segment but instead
only flush events are sent to it to reset the EOS state.

As a result, the muxer will keep stream state and e.g. mpegtsmux will
keep the packet continuity counter continuous between segments as needed
by hlssink2.
Comment 2 Sebastian Dröge (slomo) 2018-03-29 16:21:37 UTC 
Created attachment 370306 [details] [review]
mpegtsmux: Resend initial segments and header sections after FLUSH_STOP
Comment 3 Sebastian Dröge (slomo) 2018-03-29 16:21:43 UTC 
Created attachment 370307 [details] [review]
hlssink2: Use the new reset-muxer property on splitmuxsink

We don't want to reset the muxer, otherwise the continuity counter will
reset after each segment and some software gets confused. We want to
create a continuous stream.
Comment 4 Sebastian Dröge (slomo) 2018-04-03 11:38:05 UTC 
Comment on attachment 370305 [details] [review]
splitmuxsink: Add new reset-muxer property

Attachment 370305 [details] pushed as 0f1770f - splitmuxsink: Add new reset-muxer property
Comment 5 Sebastian Dröge (slomo) 2018-04-03 11:38:29 UTC 
Attachment 370306 [details] pushed as 7a2110a - mpegtsmux: Resend initial segments and header sections after FLUSH_STOP
Attachment 370307 [details] pushed as 385a68b - hlssink2: Use the new reset-muxer property on splitmuxsink