After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794610 - autogen.sh fails with automake 1.16
autogen.sh fails with automake 1.16
Status: RESOLVED FIXED
Product: libsecret
Classification: Other
Component: General
0.18.x
Other All
: Normal normal
: ---
Assigned To: libsecret maintainer(s)
libsecret maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2018-03-22 20:40 UTC by Ryan Schmidt
Modified: 2018-03-23 12:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix (341 bytes, patch)
2018-03-22 20:40 UTC, Ryan Schmidt 		committed Details | Review

Description Ryan Schmidt 2018-03-22 20:40:10 UTC 
Created attachment 370024 [details] [review]
Fix

When automake 1.16 is used, libsecret 0.18.5's autogen.sh script fails, with this message:

You must have one of automake 1.15 1.14 1.13 1.12 1.11 1.10 to compile libsecret.

Here is the MacPorts project's bug report:

https://trac.macports.org/ticket/56116

Adding 1.16 to the list of automake versions in autogen.sh allows autogen.sh, configure and build to succeed. My patch to do that is attached. It has been added to MacPorts.

This has been an issue every time a new version of automake is released. May I suggest that you change the code to assume that new versions of automake will work, rather than assume that they will fail?
Comment 1 Daiki Ueno 2018-03-23 12:34:18 UTC 
Review of attachment 370024 [details] [review]:

Thank you, I'm applying this patch, although it might make more sense to call autoreconf unconditionally as suggested in the template at https://wiki.gnome.org/Projects/GnomeCommon/Migration.