After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794588 - libgcc_s_sjlj-1.dll missing from 1.14 Windows binaries
libgcc_s_sjlj-1.dll missing from 1.14 Windows binaries
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: cerbero
1.14.0
Other Windows
: Normal blocker
: 1.14.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-03-22 06:47 UTC by Mingyi
Modified: 2018-03-23 11:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
mingw-runtime.recipe: Fix packaging of libgcc_s_sjlj (2.50 KB, patch)
2018-03-22 22:58 UTC, Nirbheek Chauhan
committed Details | Review
cerbero: Make not-found in library search fatal (2.58 KB, patch)
2018-03-22 22:58 UTC, Nirbheek Chauhan
committed Details | Review

Description Mingyi 2018-03-22 06:47:02 UTC
plugin for proxysrc/proxysink has been built, but not packaged.
official release 1.14.0 missing libgcc_s_sjlj-1.dll for windows
Comment 1 Sebastian Dröge (slomo) 2018-03-22 07:49:22 UTC
The proxy plugin is packaged now

commit b9c1b02a574595c852abb8eaee889bd9d39722b3 (HEAD -> master, origin/master, origin/HEAD)
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Thu Mar 22 09:48:03 2018 +0200

    gst-plugins-bad: Ship the proxy plugin
    
    https://bugzilla.gnome.org/show_bug.cgi?id=794588


What do you mean with libgcc_s_sjlj-1.dll not being packaged? It's included in the mingw-runtime recipe, which is pulled in by the base-system-1.0 package.
Comment 2 Mingyi 2018-03-22 09:25:00 UTC
I am working on windows,and install the windows gstreamer msi. but in the install dir could not find libgcc_s_sjlj-1.dll, so run gst-inspect failed.as GStreamer user dev with Msvc we may not install Mingw.
Comment 3 Sebastian Dröge (slomo) 2018-03-22 15:21:45 UTC
There were some other reports about this too now
Comment 4 Mingyi 2018-03-22 15:34:54 UTC
ok,thanks for your great job.
Comment 5 Nirbheek Chauhan 2018-03-22 22:58:01 UTC
Created attachment 370030 [details] [review]
mingw-runtime.recipe: Fix packaging of libgcc_s_sjlj

There's no import library for it, so look for the DLL directly in that
case.
Comment 6 Nirbheek Chauhan 2018-03-22 22:58:08 UTC
Created attachment 370031 [details] [review]
cerbero: Make not-found in library search fatal

Add an exception for the only known case: libvpx, and make the warning
fatal. The warning was totally useless because of the false positives
of libgcc_s_sjlj and libvpx.

Missing libraries should be a packaging error so we don't ship broken
binary releases.
Comment 7 Nirbheek Chauhan 2018-03-22 22:59:44 UTC
(In reply to Nirbheek Chauhan from comment #6)
> Created attachment 370031 [details] [review] [review]
> cerbero: Make not-found in library search fatal
> 
> Add an exception for the only known case: libvpx

This part of the patch is a hack, but it's better than reworking the whole system to include the case where packages only install static libraries. Especially since we should port libvpx to meson so it *does* provide DLLs.
Comment 8 Nirbheek Chauhan 2018-03-22 23:01:32 UTC
Pushed so we can get testing on all platforms with Jenkins CI. The fatal error changes might cause breakages elsewhere, but this bug is fixed now.

Attachment 370030 [details] pushed as a4f5c8c - mingw-runtime.recipe: Fix packaging of libgcc_s_sjlj
Attachment 370031 [details] pushed as 18e30cf - cerbero: Make not-found in library search fatal
Comment 9 Jan Schmidt 2018-03-23 11:23:09 UTC
New builds are uploaded to https://gstreamer.freedesktop.org/data/pkg/windows/1.14.0.1/