GNOME Bugzilla – Bug 794566
Generated code does not compile when file-descriptor-passing is used
Last modified: 2018-03-28 06:42:17 UTC
The generated code references a variable named `_fd_list` without declaring it first.
Created attachment 369966 [details] [review] gdbus: Add missing GUnixFDList variable declaration
Could you add a test-case which triggers this problem?
Just for completeness, the test-suite failures with this patch: tests/_test/main.c: In function ‘dbus_enum_string_marshalling_test_proxy_test3’: tests/_test/main.c:85010:15: error: redeclaration of ‘_fd_list’ with no linkage GUnixFDList* _fd_list; ^~~~~~~~ tests/_test/main.c:85007:15: note: previous declaration of ‘_fd_list’ was here GUnixFDList *_fd_list; ^~~~~~~~ tests/_test/main.c: In function ‘dbus_filedescriptor_client_test_proxy_test_in’: tests/_test/main.c:86139:15: error: redeclaration of ‘_fd_list’ with no linkage GUnixFDList* _fd_list; ^~~~~~~~ tests/_test/main.c:86136:15: note: previous declaration of ‘_fd_list’ was here GUnixFDList *_fd_list; ^~~~~~~~ tests/_test/main.c: In function ‘dbus_filedescriptor_errors_client_test_proxy_test’: tests/_test/main.c:87023:15: error: redeclaration of ‘_fd_list’ with no linkage GUnixFDList* _fd_list; ^~~~~~~~ tests/_test/main.c:87020:15: note: previous declaration of ‘_fd_list’ was here GUnixFDList *_fd_list; ^~~~~~~~
Created attachment 370220 [details] [review] gdbus: Fix missing declaration of _fd_list for async methods
Attachment 370220 [details] pushed as 724397a - gdbus: Fix missing declaration of _fd_list for async methods