After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 794558 - Glib documentation fails to build in meson builds
Glib documentation fails to build in meson builds
Status: RESOLVED OBSOLETE
Product: glib
Classification: Platform
Component: docs
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks: 790954
 
 
Reported: 2018-03-21 10:15 UTC by LRN
Modified: 2018-05-24 20:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove nonexisting section from gio-docs (914 bytes, patch)
2018-03-21 10:15 UTC, LRN
none Details | Review
Try to fix a href to gdbus-example-objectmanager.xml (1.83 KB, patch)
2018-03-21 10:16 UTC, LRN
none Details | Review
Fix gio tool documentation (1.33 KB, patch)
2018-03-28 18:51 UTC, LRN
none Details | Review

Description LRN 2018-03-21 10:15:45 UTC
On glib side the errors are mostly due to non-existing sections
and broken references. There are other problems, but those can be
fixed in meson.

I don't really understand how gtk-doc works, so this is just me
throwing changes at the docs to see if they fix anything.
Comment 1 LRN 2018-03-21 10:15:54 UTC
Created attachment 369949 [details] [review]
Remove nonexisting section from gio-docs
Comment 2 LRN 2018-03-21 10:16:01 UTC
Created attachment 369950 [details] [review]
Try to fix a href to gdbus-example-objectmanager.xml

In the end this doesn't seem to be working (the example is still
missing from the generated documentation page), but at least
gtk-doc does not error out anymore.
Comment 3 Emmanuele Bassi (:ebassi) 2018-03-28 11:15:10 UTC
Review of attachment 369949 [details] [review]:

Okay
Comment 4 Emmanuele Bassi (:ebassi) 2018-03-28 11:17:37 UTC
(In reply to LRN from comment #2)
> Created attachment 369950 [details] [review] [review]
> Try to fix a href to gdbus-example-objectmanager.xml

The issue is that the location of the generated file is in the builddir, and that may not match what gtk-doc expects.

It should be possible to add the build directory to the search paths for xsltproc/gtk-doc, but I'm not sure how.
Comment 5 LRN 2018-03-28 18:51:57 UTC
Created attachment 370258 [details] [review]
Fix gio tool documentation

* Remove the xml header from gio.xml (other tool xmls don't have them).
* Add gio.xml to content_files list

This turned out to be a better solution than simply removing gio.xml from gio-docs.xml
Comment 6 LRN 2018-03-28 19:45:43 UTC
(In reply to Emmanuele Bassi (:ebassi) from comment #4)
> (In reply to LRN from comment #2)
> > Created attachment 369950 [details] [review] [review] [review]
> > Try to fix a href to gdbus-example-objectmanager.xml
> 
> The issue is that the location of the generated file is in the builddir, and
> that may not match what gtk-doc expects.
> 
> It should be possible to add the build directory to the search paths for
> xsltproc/gtk-doc, but I'm not sure how.

I don't think so. In this case the gdbus-example-objectmanager.xml is included verbatim, from the source directory. It's not about the generated .c file.
Comment 7 LRN 2018-03-31 14:09:35 UTC
I've checked out the situation with gdbus-example-objectmanager.xml, and i think that it should be possible to give xsltproc a list of directories to include stuff from. In fast, gtk-doc *does* give such a list, but passing it around is broken on W32, because no one is using path separators consistently.

Would someone please test attachment 369950 [details] [review] (and other meson doc fixes currently in bugzilla) on a non-W32 machine and see if it works there? If so, then this patch can be just accepted as-is (fixes for W32-specific issues are discussed in bug 788911).
Comment 8 GNOME Infrastructure Team 2018-05-24 20:18:57 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/glib/issues/1356.