GNOME Bugzilla – Bug 794253
Desupport RHEL / CentOS 5 and raise minimum required versions to glibmm 2.14.0 and gtkmm 2.16.0
Last modified: 2018-08-22 16:32:22 UTC
Hi Curtis, This is for after GParted 0.31.0 has been released. Thanks, Mike -- PATCHSET OVERVIEW: As of 31 March 2017 RHEL / CentOS 5 reached the end of their support [1][2]. Therefore remove code which supports them. This makes RHEL / CentOS 6 the oldest supported distribution. So the minimum required versions of glibmm and gtkmm can be increased dropping some autoconf checks and conditional code supporting older versions of these libraries. This will undo the bulk of these these previous bug fixes: * GParted 0.21.0 Bug 738706 - Add support for ext4 on RHEL/CentOS 5.x * GParted 0.16.1 Bug 695279 - Fix GParted doesn't compile on RHEL / CentOS 5.9 [1] Red Hat Enterprise Linux Life Cycle https://access.redhat.com/support/policy/updates/errata#Life_Cycle_Dates [2] Subject: CentOS Linux 5 EOL https://lists.centos.org/pipermail/centos-announce/2017-April/022350.html
Created attachment 369568 [details] [review] Desupport RHEL / CentOS 5 (v1) Here's patchset v1 for this. Performed testing: [PASS] make distcheck every commit in the patchset on CentOS 6 [PASS] make distcheck head of the patchset on CentOS 7 [PASS] make distcheck head of the patchset on Ubuntu 14.04 LTS [PASS] make distcheck head of the patchset on Debian 8 [PASS] make distcheck head of the patchset on Fedora 27
Hi Mike, Thank you for this patch set to simplify the code and improve support for 'make distcheck'. I tested each of the supported operations for ext4 on kubuntu 16.04 in addition to confirming that this patch set works with 'make distcheck' on openSUSE 42.3. Hence this patch set looks good to me. Patch set v1 contained in comment #1 has been committed to the git repository for inclusion in the next release of GParted. The relevant git commits can be viewed at the following links: Remove checks for e4fsprogs commands (#794253) https://git.gnome.org/browse/gparted/commit/?id=6c4ab5dc28a14f3bef2d1c1a24da219381d513f0 Simplify ext2::get_filesystem_support() with regard ext4 support (#794253) https://git.gnome.org/browse/gparted/commit/?id=de6e70d933286f3c65187470c9852fb6d8a60a7d Raise minimum required glibmm version to 2.14.0 (#794253) https://git.gnome.org/browse/gparted/commit/?id=07f58ed82bca9d7d6e01516206cfa46b919222a6 Increase minimum required gtkmm to 2.11.1 (#794253) https://git.gnome.org/browse/gparted/commit/?id=0ab2adb67fd3ef8e75698c596245b81762b8c7c2 Increase minimum required gtkmm to 2.16.0 (#794253) https://git.gnome.org/browse/gparted/commit/?id=fc215d0c2e07539374622de4dfc0bffff3bf44de Use /dev/disk/by-id/ to get device symlink in test_BlockSpecial https://git.gnome.org/browse/gparted/commit/?id=7fe41480749c795dfb79daeba7b058cece2dfdd2 Curtis
This enhancement was included in the GParted 0.32.0 release on August 22, 2018.