After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793933 - pad: use the template gtype if specified
pad: use the template gtype if specified
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
unspecified
Other All
: Normal normal
: 1.13.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 793917
 
 
Reported: 2018-02-28 18:53 UTC by Mathieu Duponchelle
Modified: 2018-02-28 23:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
pad: use the template gtype if specified (922 bytes, patch)
2018-02-28 18:53 UTC, Mathieu Duponchelle 		needs-work Details | Review
pad, ghostpad: use the template gtype if specified (2.65 KB, patch)
2018-02-28 23:39 UTC, Mathieu Duponchelle 		committed Details | Review

Description Mathieu Duponchelle 2018-02-28 18:53:23 UTC 
self-explanatory
Comment 1 Mathieu Duponchelle 2018-02-28 18:53:29 UTC 
Created attachment 369112 [details] [review]
pad: use the template gtype if specified
Comment 2 Sebastian Dröge (slomo) 2018-02-28 19:20:43 UTC 
Comment on attachment 369112 [details] [review]
pad: use the template gtype if specified

Looks good, but same change needed for:
- gst_pad_new_from_static_template() (with GST_PAD_TEMPLATE_GTYPE())
- gst_ghost_pad_new_from_template()
- gst_ghost_pad_new_no_target_from_template()
Comment 3 Sebastian Dröge (slomo) 2018-02-28 19:21:28 UTC 
(In reply to Sebastian Dröge (slomo) from comment #2)
> - gst_pad_new_from_static_template() (with GST_PAD_TEMPLATE_GTYPE())

Ignore that one :)
Comment 4 Sebastian Dröge (slomo) 2018-02-28 22:30:54 UTC 
Might also want to add an assertion for the GTypes being correct. I.e. a ghostpad subclass / pad subclass.
Comment 5 Mathieu Duponchelle 2018-02-28 23:39:32 UTC 
Created attachment 369119 [details] [review]
pad, ghostpad: use the template gtype if specified

Also make sure the GType passed to the with_gtype versions
of the template constructors is_a GstPad
Comment 6 Mathieu Duponchelle 2018-02-28 23:50:26 UTC 
Attachment 369119 [details] pushed as 7847e69 - pad, ghostpad: use the template gtype if specified