After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793751 - qtdemux_parse_segments: remove superfluous variable
qtdemux_parse_segments: remove superfluous variable
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal enhancement
: 1.15.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-02-23 12:50 UTC by Alicia Boya García
Modified: 2018-05-18 15:34 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
qtdemux_parse_segments: remove superfluous variable (3.03 KB, patch)
2018-02-23 12:50 UTC, Alicia Boya García
committed Details | Review

Description Alicia Boya García 2018-02-23 12:50:31 UTC
`count` and `i` are used interchangeably, why not use a single variable?

The patch attached does that, renaming both to segment_number.

Additionally, at the end of the loop, usages of segment_number are changed to
n_segments for better readability (segment_number is a loop index and should
not be used outside of the loop in presence of better alternatives).
Comment 1 Alicia Boya García 2018-02-23 12:50:35 UTC
Created attachment 368824 [details] [review]
qtdemux_parse_segments: remove superfluous variable
Comment 2 Thibault Saunier 2018-05-18 15:34:03 UTC
Attachment 368824 [details] pushed as c097289 - qtdemux_parse_segments: remove superfluous variable