After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793738 - rtsp-media: fix RECORD getting stuck
rtsp-media: fix RECORD getting stuck
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-rtsp-server
unspecified
Other All
: High blocker
: 1.13.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-02-22 23:27 UTC by Mathieu Duponchelle
Modified: 2018-02-23 15:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
rtsp-media: fix RECORD getting stuck (2.29 KB, patch)
2018-02-22 23:28 UTC, Mathieu Duponchelle
committed Details | Review

Description Mathieu Duponchelle 2018-02-22 23:27:58 UTC
The test_record case was working because async=false had
been added in https://bugzilla.gnome.org/show_bug.cgi?id=757488
but that was incorrect, as it should not be needed.

Removing async=false made the test fail as expected, this is
fixed by not trying to preroll when preparing the media for
RECORD, as start_prepare is called upon receiving ANNOUNCE,
and our peer will not start sending media until it has received
a response to that request, and sent and received a response
to RECORD as well, thus obviously preventing preroll.
Comment 1 Mathieu Duponchelle 2018-02-22 23:28:04 UTC
Created attachment 368808 [details] [review]
rtsp-media: fix RECORD getting stuck
Comment 2 Mathieu Duponchelle 2018-02-23 15:20:40 UTC
Attachment 368808 [details] pushed as ddb0d83 - rtsp-media: fix RECORD getting stuck