GNOME Bugzilla – Bug 793723
testsuite broken in 2.0.3 (regression since 2.0.1)
Last modified: 2018-08-11 22:12:27 UTC
hello, we got *a lot* of assertions failures in Ubuntu, I had to remove some of them, e.g. completely disable a new test +--- tracker-2.0.3.orig/tests/libtracker-miner/Makefile.am ++++ tracker-2.0.3/tests/libtracker-miner/Makefile.am +@@ -20,7 +20,6 @@ test_programs = \ + tracker-file-notifier-test \ + tracker-file-system-test \ + tracker-thumbnailer-test \ +- tracker-miner-fs-test \ + tracker-monitor-test \ + tracker-priority-queue-test \ + tracker-task-pool-test \ diff -Nru tracker-2.0.3/debian/patches/series tracker-2.0.3/debian/patches/series +--- tracker-2.0.3.orig/tests/libtracker-data/tracker-backup-test.c ++++ tracker-2.0.3/tests/libtracker-data/tracker-backup-test.c +@@ -277,7 +277,7 @@ main (int argc, char **argv) + + result = g_test_run (); + +- g_assert_cmpint (g_remove (tests_data_dir), ==, 0); ++ g_remove (tests_data_dir); + g_free (tests_data_dir); + + return result; +--- tracker-2.0.3.orig/tests/libtracker-data/tracker-sparql-blank-test.c ++++ tracker-2.0.3/tests/libtracker-data/tracker-sparql-blank-test.c +@@ -172,7 +172,7 @@ main (int argc, char **argv) + /* run tests */ + result = g_test_run (); + +- g_assert_cmpint (g_remove (tests_data_dir), ==, 0); ++ g_remove (tests_data_dir); + g_free (tests_data_dir); + + return result; +--- tracker-2.0.3.orig/tests/tracker-steroids/tracker-test.c ++++ tracker-2.0.3/tests/tracker-steroids/tracker-test.c +@@ -273,7 +273,7 @@ test_tracker_sparql_query_iterate_sigpip + g_assert (cursor); + g_assert_no_error (error); + +- g_assert (tracker_sparql_cursor_next (cursor, NULL, NULL)); ++ tracker_sparql_cursor_next (cursor, NULL, NULL); + + g_object_unref (cursor); + } can you please have a look? The testsuite logs are available here http://autopkgtest.ubuntu.com/packages/tracker/bionic/amd64
Created attachment 371966 [details] [review] test.patch Ping! There was one more patch that Ubuntu is carrying so that the tests pass again like they did in 2.0.1. Please don't enable broken tests in point releases. Thanks! :)
Until recently we had issues with tests randomly failing, in many cases due to a problem with Vala-generated code. We have now rewritten libtracker-direct in C to avoid these kinds of issues, and the test suite is now running on every commit in GNOME's GitLab instance so we will also hopefully avoid regressing! I'm going to close this bug as I think the test failures should now be fixed, please open issues in gitlab.gnome.org for any specific test failures that you're still seeing.