After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793688 - gtk: fix compiler warning with recent glib versions
gtk: fix compiler warning with recent glib versions
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.13.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-02-21 10:18 UTC by Arnaud B.
Modified: 2018-02-21 11:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix warning. (790 bytes, patch)
2018-02-21 10:18 UTC, Arnaud B. 		committed Details | Review

Description Arnaud B. 2018-02-21 10:18:23 UTC 
Created attachment 368698 [details] [review]
Fix warning.

There’s a warning during the build, that makes GNOME Flatpak SDK master image fail[1].

  gstgtkbasesink.c: In function ‘gst_gtk_base_sink_change_state’:
  gstgtkbasesink.c:399:16: error: assignment from incompatible pointer type [-Werror=incompatible-pointer-types]
           window = g_object_ref (gtk_sink->window);
                  ^
  cc1: all warnings being treated as errors

Here is a simple cast patch that fixes it.

[1] warning, big! http://sdkbuilder1.gnome.org/logs/build-2018-02-21-082201/build-gnome-sdk-images-master-x86_64.txt
Comment 1 Tim-Philipp Müller 2018-02-21 11:37:55 UTC 
commit b348ddfdedf121b44d7cbf74c8dc0efd3e20b42c
Author: Arnaud Bonatti <arnaud.bonatti@gmail.com>
Date:   Wed Feb 21 11:12:10 2018 +0100

    gtk: fix compiler warning with recent glib
    
    https://bugzilla.gnome.org/show_bug.cgi?id=793688