After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793684 - Lack of nullable annotations in GOFileOpener
Lack of nullable annotations in GOFileOpener
Status: RESOLVED FIXED
Product: libgoffice
Classification: Other
Component: General
GIT
Other Linux
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2018-02-21 08:29 UTC by Hiroshi Hatake
Modified: 2018-03-30 18:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for adding nullable annotions in GOFileSaver. (2.76 KB, application/octet-stream)
2018-02-21 08:29 UTC, Hiroshi Hatake 		  Details
Patch for adding nullable annotions in GOFileSaver. (2.17 KB, patch)
2018-02-21 08:42 UTC, Hiroshi Hatake 		none Details | Review

Description Hiroshi Hatake 2018-02-21 08:29:33 UTC 
Created attachment 368689 [details]
Patch for adding nullable annotions in GOFileSaver.

Attached patch adds `nullable` annotations.

Because our gi-based bindings want to refer `nullable` markers to generate
human friendly methods with gi information.
Comment 1 Hiroshi Hatake 2018-02-21 08:42:37 UTC 
Created attachment 368691 [details] [review]
Patch for adding nullable annotions in GOFileSaver.
Comment 2 Morten Welinder 2018-03-30 18:44:40 UTC 
Fixed.  I prefer getting rid of the "or NULL" text when the nullable
annotation is used.

(These strings are *old* and might actually predate even the allow-none
annotation in introspection.)
Comment 3 Morten Welinder 2018-03-30 18:44:49 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Once that release is available, you may want to check for a software upgrade provided by your Linux distribution.