After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793642 - planner-task-view.c:855: bad compare ?
planner-task-view.c:855: bad compare ?
Status: RESOLVED FIXED
Product: planner
Classification: Other
Component: General
0.14.6
Other Linux
: Normal normal
: ---
Assigned To: planner-maint
planner-maint
Depends on:
Blocks:
 
 
Reported: 2018-02-20 12:23 UTC by dcb
Modified: 2018-03-16 08:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description dcb 2018-02-20 12:23:32 UTC 
planner-task-view.c:855]: (warning) The expression 'strcmp(id,"assigned-to") != 0' is suspicious. It overlaps 'strcmp(id,"complete") == 0'.

Source code is

                strcmp (id, "complete") == 0 ||
                strcmp (id, "assigned-to")) {

Suggest new code

                strcmp (id, "complete") == 0 ||
                strcmp (id, "assigned-to") == 0) {
Comment 1 Alexandre Franke 2018-03-16 08:53:40 UTC 
Thanks for the report. A fix has been pushed to master as 1a68e27.