GNOME Bugzilla – Bug 793605
webrtcdsp: add support for using floating point planar buffers directly
Last modified: 2018-08-03 10:27:19 UTC
The webrtc audio processing library internally uses floating point arithmetics and works on planar buffers. In order to avoid conversion and interleaving/deinterleaving inside the webrtc audio processing code, this patchset enables the use of F32 non-interleaved buffers directly. In order to do this, this patchset also introduces a new GstPlanarAudioAdapter class in libgstbadaudio, which can be useful in other places too in the future (GstAudioEncoder for example...) Patches can be found at: https://gitlab.collabora.com/gkiagia/gst-plugins-bad/commits/webrtc_planar_audio Obviously, this depends on https://bugzilla.gnome.org/show_bug.cgi?id=751605
Created attachment 373142 [details] [review] libs: audio: add new GstPlanarAudioAdapter class
Created attachment 373143 [details] [review] GstPlanarAudioAdapter: copy pts, dts and offset tracking from GstAdapter
Created attachment 373144 [details] [review] webrtcdsp: add support for using F32/non-interleaved buffers
Merged. Nicolas gave me the OK over a chat we had. commit d299c27892b9eff24df7107f979e93856c06672a Author: George Kiagiadakis <george.kiagiadakis@collabora.com> Date: Mon Feb 19 18:30:13 2018 +0200 webrtcdsp: add support for using F32/non-interleaved buffers This is the native format that is in use by the webrtc audio processing library internally, so this avoids internal {de,}interleaving and format conversion (S16->F32 and back) https://bugzilla.gnome.org/show_bug.cgi?id=793605 commit 0591bc934a227d1c269b406c365178f77a8434f0 Author: George Kiagiadakis <george.kiagiadakis@collabora.com> Date: Mon Feb 19 11:48:01 2018 +0200 GstPlanarAudioAdapter: copy pts, dts and offset tracking from GstAdapter https://bugzilla.gnome.org/show_bug.cgi?id=793605 commit 9cf58eb3e4621ea8261e1443bda496b6da9f8833 Author: George Kiagiadakis <george.kiagiadakis@collabora.com> Date: Fri Feb 16 15:55:45 2018 +0200 libs: audio: add new GstPlanarAudioAdapter class This is a GstAdapter, but for planar audio buffers. https://bugzilla.gnome.org/show_bug.cgi?id=793605