After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793584 - meson: Use .dylib suffix if darwin
meson: Use .dylib suffix if darwin
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
unspecified
Other Mac OS
: Normal normal
: 1.13.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-02-19 06:43 UTC by Justin Kim
Modified: 2018-02-23 23:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
meson: Use .dylib suffix if darwin (1000 bytes, patch)
2018-02-19 06:43 UTC, Justin Kim
committed Details | Review

Description Justin Kim 2018-02-19 06:43:51 UTC
Created attachment 368541 [details] [review]
meson: Use .dylib suffix if darwin

For Mac OS, GST_EXTRA_MODULE_SUFFIX should be set as '.dylib'.
    Otherwise, GStreamer fails to load its plugins.
Comment 1 Tim-Philipp Müller 2018-02-21 14:59:33 UTC
Unclear whether this needs fixing in Meson or not, apparently autotools is the exception to the rule here by creating .so files. In any case, doesn't hurt to add the extra prefix.

commit 580e3a799e588f751cbd2ad6d344b67801f1706e
Author: Justin Kim <justin.kim@collabora.com>
Date:   Mon Feb 19 15:39:46 2018 +0900

    meson: Use .dylib suffix if darwin
    
    For Mac OS, GST_EXTRA_MODULE_SUFFIX should be set as '.dylib'.
    Otherwise, GStreamer fails to load its plugins.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=793584
Comment 2 Daniel Macks 2018-02-23 21:32:18 UTC
On OS X, .dylib is the standard extension for linkable libraries whereas .so (or sometimes .bundle) is standard for runtime loadable modules. There is a linker-level difference, so different extensions to coincide with it. On linux, I don't think there is a binary difference and .so is used everywhere.
Comment 3 Tim-Philipp Müller 2018-02-23 23:13:43 UTC
Thanks. There is a Meson issue related to this with more background, and iirc the conclusion was that most other build systems (other than autotools) also output .dylib for modules.

In any case, this may or may not be an issue in Meson, but until it's fixed in meson we need to check the extra suffix to make sure our built plugins are picked up.