Bug 793560 – gst-python: tarball missing __init__.py files

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 793560 - gst-python: tarball missing __init__.py files


Summary:	gst-python: tarball missing __init__.py files


Status:	RESOLVED FIXED

Product:	GStreamer
Classification:	Platform
Component:	gst-python
Version:	unspecified
Hardware:	Other Windows

Importance:	Normal blocker
Target Milestone:	1.13.90
Assigned To:	GStreamer Maintainers
QA Contact:	GStreamer Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2018-02-18 11:38 UTC by Christoph Reiter (lazka)
Modified:	2018-02-22 22:07 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
makefiles: Add missing dist files (1.81 KB, patch) 2018-02-18 15:09 UTC, Nicolas Dufresne (ndufresne)	committed	Details \| Review

Description Christoph Reiter (lazka) 2018-02-18 11:38:40 UTC

gi/__init__.py and gi/overrides/__init__.py are missing from the tarball.
The makefile references them (for a non-srcdir build at least) and fails.

Comment 1 Nicolas Dufresne (ndufresne) 2018-02-18 14:50:30 UTC

Oh, let's fix this before 1.13.2/1.14.

Comment 2 Nicolas Dufresne (ndufresne) 2018-02-18 15:09:19 UTC

Created attachment 368517 [details] [review]
makefiles: Add missing dist files

Comment 3 Nicolas Dufresne (ndufresne) 2018-02-18 15:10:29 UTC

This adds the missing file, but "distcheck" still fails. 

make[3]: Entering directory '/home/nicolas/Sources/gstreamer-master/gst-python/gst-python-1.13.1.1/_build/sub/testsuite'
/usr/bin/python ../../../testsuite/runtests.py test_gst.py test_types.py
Traceback (most recent call last):

+ Trace 238402

File "../../../testsuite/runtests.py", line 61 in <module>
```
suite = _tests_suite()
```
File "../../../testsuite/runtests.py", line 44 in _tests_suite
```
return loader.loadTestsFromNames(testcases)
```
File "/usr/lib64/python2.7/unittest/loader.py", line 130 in loadTestsFromNames
```
suites = [self.loadTestsFromName(name, module) for name in names]
```
File "/usr/lib64/python2.7/unittest/loader.py", line 91 in loadTestsFromName
```
module = __import__('.'.join(parts_copy))
```
File "/home/nicolas/Sources/gstreamer-master/gst-python/gst-python-1.13.1.1/testsuite/test_gst.py", line 23 in <module>
```
from common import TestCase, unittest
```
File "/home/nicolas/Sources/gstreamer-master/gst-python/gst-python-1.13.1.1/testsuite/common.py", line 37 in <module>
```
from gi.repository import Gst
```
File "/usr/lib64/python2.7/site-packages/gi/importer.py", line 146 in load_module
```
dynamic_module = load_overrides(introspection_module)
```
File "/usr/lib64/python2.7/site-packages/gi/overrides/__init__.py", line 125 in load_overrides
```
override_mod = importlib.import_module(override_package_name)
```
File "/usr/lib64/python2.7/importlib/__init__.py", line 37 in import_module
```
__import__(name)
```
File "/home/nicolas/Sources/gstreamer-master/gst-python/build/gi/overrides/Gst.py", line 567 in <module>
```
from . import _gi_gst
```

ImportError: cannot import name _gi_gst

Comment 4 Edward Hervey 2018-02-22 10:20:18 UTC

Review of attachment 368517 [details] [review]:

::: testsuite/Makefile.am
@@ +12,3 @@
+	gstpython.supp \
+	meson.build \
+	mesonconfig.py \

mesonconfig.py is a generated file, no ? Doesn't exist here.

Comment 5 Nicolas Dufresne (ndufresne) 2018-02-22 14:20:37 UTC

Oh, oops, I thought all meson generated stuff was in the build directory. Seems like a meson bug, I'll fix the commit.

Comment 6 Nicolas Dufresne (ndufresne) 2018-02-22 22:07:43 UTC

Attachment 368517 [details] pushed as 146b8cc - makefiles: Add missing dist files