After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 793518 - gsd-power-manager/handle_set_property_other: don't set gerror twice
gsd-power-manager/handle_set_property_other: don't set gerror twice
Status: RESOLVED OBSOLETE
Product: gnome-settings-daemon
Classification: Core
Component: power
3.27.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2018-02-16 18:45 UTC by Guido Günther
Modified: 2019-03-20 11:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-gsd-power-manager-handle_set_property_other-don-t-se.patch (1.24 KB, patch)
2018-02-16 18:45 UTC, Guido Günther 		none Details | Review

Description Guido Günther 2018-02-16 18:45:21 UTC 
If backlight_set_percentage already sets an error don't overwrite it with a generic one setting up glib.

Patch forthcoming.
Comment 1 Guido Günther 2018-02-16 18:45:59 UTC 
Created attachment 368440 [details] [review]
0001-gsd-power-manager-handle_set_property_other-don-t-se.patch
Comment 2 Benjamin Berg 2018-07-11 13:43:48 UTC 
Review of attachment 368440 [details] [review]:

Looks good to me in general. This probably conflicts with the pending backlight brightness changes, but that should be fine.
Comment 3 GNOME Infrastructure Team 2019-03-20 11:53:47 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-settings-daemon/issues/387.