Bug 793274 – Event, Message have empty constructors and confusing constructors that create arbitrary typed events/messages

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 793274 - Event, Message have empty constructors and confusing constructors that create arbitrary typed events/messages


Summary:	Event, Message have empty constructors and confusing constructors that create...

Attachments
event: Make sure all constructor have a proper name (13.23 KB, patch) 2018-03-13 13:05 UTC, Thibault Saunier	committed	Details \| Review
message: Name all constructors (22.87 KB, patch) 2018-03-13 13:17 UTC, Thibault Saunier	committed	Details \| Review

Description Sebastian Dröge (slomo) 2018-02-07 19:20:20 UTC

The empty constructors are creating an EOS event/message, which seems rather confusing.

Comment 1 Sebastian Dröge (slomo) 2018-02-07 19:22:40 UTC

Similarly, new Gst.Event(true) gives a flush-stop event. Obviously :)

This should be fixed, it makes code hard to understand.

Comment 2 Thibault Saunier 2018-03-13 13:05:50 UTC

Created attachment 369614 [details] [review]
event: Make sure all constructor have a proper name

Fixes

Comment 3 Thibault Saunier 2018-03-13 13:06:25 UTC

Attachment 369614 [details] pushed as 94f4d85 - event: Make sure all constructor have a proper name

Comment 4 Thibault Saunier 2018-03-13 13:17:28 UTC

Created attachment 369615 [details] [review]
message: Name all constructors

And fix examples.

Fixes

Comment 5 Thibault Saunier 2018-03-13 13:17:45 UTC

Attachment 369615 [details] pushed as bbe45eb - message: Name all constructors