GNOME Bugzilla – Bug 793217
[review] lr/nma-gtk-builder: Port the mobile wizard and VPN password dialog to GtkBuilder
Last modified: 2018-03-14 08:02:34 UTC
Turning the widget creation declarative essentially makes the bits more maintainable.
> nma-mobile-wizard: turn into a templated GtkWidget +typedef struct { + GtkAssistant parent; +} NMAMobileWizard; + +typedef struct { + GtkAssistantClass parent; +} NMAMobileWizardClass; do you expect somebody to subclass these? Otherwise, make them not public API but opaque types. rest lgtm
Looks good to me.
Merged, with fixup to make NMAMobileWizard and NMAMobileWizardClass not public, as Thomas suggested.