After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792925 - Remove gdk_window_process_updates call
Remove gdk_window_process_updates call
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-01-26 11:10 UTC by Timm Bäder
Modified: 2018-01-28 15:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
scrol-view: Remove a gdk_window_process_updates call (917 bytes, patch)
2018-01-26 11:10 UTC, Timm Bäder
none Details | Review

Description Timm Bäder 2018-01-26 11:10:01 UTC
IIRC eog had a similar problem about scrollbars that don't update,
Comment 1 Timm Bäder 2018-01-26 11:10:13 UTC
Created attachment 367469 [details] [review]
scrol-view: Remove a gdk_window_process_updates call
Comment 2 Timm Bäder 2018-01-26 11:12:31 UTC
Sorry, the Submit button is directly next to the "Add Attachment" button for some reason :|

We recently came to the conclusion that VTE's scrollbars have a similar problem due to an out-of-band gdk_window_process_updates() call processing the expose event, see the last few comments of https://bugzilla.gnome.org/show_bug.cgi?id=771899 .

I've tried looking why that call exists in the eog source in the first place but it was added before the project even moved to git and just like in VTE, that reason seems long gone.
Comment 3 Felix Riemann 2018-01-28 15:59:58 UTC
Yes, I was wondering about that one too lately as it started showing up in the deprecated API list. The non-updating scrollbars were "fixed" with a workaround in GTK.

commit fbfd90f1eb6a40aea778d042ed1118d155ac6370
Author: Timm Bäder <>
Date:   Fri Jan 26 12:09:58 2018 +0100

    scroll-view: Remove a gdk_window_process_updates call
    
    gtk+ will process the updates itself once the time comes.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=792925
---
This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.