After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792890 - Automatic suspend values must include new default of "20 minutes"
Automatic suspend values must include new default of "20 minutes"
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Power
git master
Other Linux
: Normal normal
: ---
Assigned To: Richard Hughes
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-01-25 06:30 UTC by Roddy Shuler
Modified: 2018-01-25 23:01 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
power: Add 20 and 25 minutes suspend timeouts (1.20 KB, patch)
2018-01-25 09:36 UTC, Bastien Nocera
none Details | Review
power: Add 20 and 25 minutes suspend timeouts (1.20 KB, patch)
2018-01-25 22:59 UTC, Bastien Nocera
committed Details | Review

Description Roddy Shuler 2018-01-25 06:30:49 UTC
As discussed on https://bugzilla.gnome.org/show_bug.cgi?id=681869#c25...

The recent change to gnome-settings-daemon to default to suspend after 20 minutes of inactivity causes a bug in gnome-control-center, because "20 minutes" is not an available option in the UI.  Instead, it is displayed as "2 hours".  The closest available options in the current UI are "15 minutes" and "30 minutes", but 20 minutes was selected to comply with the EU energy regulations.

Unfortunately, the current design of the UI has each option as a separate translatable string, so there is a bit of bookkeeping needed to make this right for all supported languages.
Comment 1 Bastien Nocera 2018-01-25 09:36:05 UTC
Created attachment 367416 [details] [review]
power: Add 20 and 25 minutes suspend timeouts

Pad out the 15-30 minutes mark with 5 minute increments. This also means
that the new 20-minute default for suspending is now in the list, and
will be selected when the panel is opened, rather than the 30 minutes
option.

See https://bugzilla.gnome.org/show_bug.cgi?id=681869
Comment 2 Georges Basile Stavracas Neto 2018-01-25 21:24:11 UTC
Review of attachment 367416 [details] [review]:

Patch looks good, but misses two '<' and thus it's not buildable.

Can push directly after fixing that

::: panels/power/power.ui
@@ +16,3 @@
+      <row>
+        <col id="0" translatable="yes">20 minutes</col>
+        <col id="1">1200/col>

Missing '<'

@@ +20,3 @@
+      <row>
+        <col id="0" translatable="yes">25 minutes</col>
+        <col id="1">1500/col>

Missing '<'
Comment 3 Bastien Nocera 2018-01-25 22:59:21 UTC
Created attachment 367445 [details] [review]
power: Add 20 and 25 minutes suspend timeouts

Pad out the 15-30 minutes mark with 5 minute increments. This also means
that the new 20-minute default for suspending is now in the list, and
will be selected when the panel is opened, rather than the 30 minutes
option.

See https://bugzilla.gnome.org/show_bug.cgi?id=681869
Comment 4 Bastien Nocera 2018-01-25 23:01:45 UTC
Attachment 367445 [details] pushed as eb88ce5 - power: Add 20 and 25 minutes suspend timeouts