After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792860 - shell-recorder cursor positions do not honor cursor hostspots
shell-recorder cursor positions do not honor cursor hostspots
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2018-01-24 09:45 UTC by Florian Zwoch
Modified: 2018-02-07 19:05 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Florian Zwoch 2018-01-24 09:45:13 UTC
Currently I think the cursor hot spots are not considered when drawing the cursor at the specific coordinates. This results in some cursors being a bit of in the recorder compared to what you see on screen.

cursor_hot_x and
cursor_hot_y

are actually in the code and are being used at the the drawing step:

cairo_set_source_surface (cr,
  recorder->cursor_image,
  recorder->pointer_x - recorder->cursor_hot_x - recorder->area.x,
  recorder->pointer_y - recorder->cursor_hot_y - recorder->area.y);

However these values are never being set. Perhaps the "on_cursor_changed" routine that reads the current cursor image buffer should also read the current hot spot coordinates from the cursor?
Comment 1 Florian Müllner 2018-02-07 19:05:23 UTC
Fixed in 6f0c187cf4.
Comment 2 Florian Müllner 2018-02-07 19:05:48 UTC
I meant commit 6f0c187cf4.