After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792765 - PATCH: meta-monitor: Set MINIMUM_LOGICAL_HEIGHT to 480
PATCH: meta-monitor: Set MINIMUM_LOGICAL_HEIGHT to 480
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2018-01-21 21:48 UTC by Hans de Goede
Modified: 2018-01-23 03:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] meta-monitor: Set MINIMUM_LOGICAL_HEIGHT to 480 (1.21 KB, patch)
2018-01-21 21:48 UTC, Hans de Goede 		none Details | Review
[PATCH] monitor: Set MINIMUM_LOGICAL_HEIGHT to 480 (1.20 KB, patch)
2018-01-22 17:15 UTC, Hans de Goede 		committed Details | Review

Description Hans de Goede 2018-01-21 21:48:39 UTC 
Created attachment 367189 [details] [review]
[PATCH] meta-monitor: Set MINIMUM_LOGICAL_HEIGHT to 480

Hi,

Not sure if bugzilla still is the proper patch submission route with the gitlab move coming up, but since I don't know better here I am :)

Using 800x600 as minimum logical size is very 4:3 thinking, while a lot of
modern devices are 16:9. The specific reason for this commit is to allow
1.5 scaling at mini-laptops (clamshell devices) with e.g. a 5.5"
1280x720 screen. Given that this device has a keyboard, one obviously
is not holding it very close to ones eyes and at 220 dpi that means the text
is too small at scale 1.0. For one real world example of such a device see:
https://en.wikipedia.org/wiki/GPD_Win

Regards,

Hans
Comment 1 Jonas Ådahl 2018-01-22 02:01:13 UTC 
Review of attachment 367189 [details] [review]:

commit subject should be "monitor: Set ..". Otherwise lgtm.

Also, bugzilla is the way to go until the migration has happened, so you're in the right place!
Comment 2 Hans de Goede 2018-01-22 17:15:30 UTC 
Created attachment 367233 [details] [review]
[PATCH] monitor: Set MINIMUM_LOGICAL_HEIGHT to 480

Hi Jonas,

Here is a new version with the subject fixed up. I still don't have gnome commit access so if you can push this for me, that would be great.

Regards,

Hans
Comment 3 Jonas Ådahl 2018-01-23 03:09:50 UTC 
Backported to gnome-3-26 too.