After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792649 - qtmux: Allow configuring trak timescale per pad/trak
qtmux: Allow configuring trak timescale per pad/trak
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal enhancement
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 792680
 
 
Reported: 2018-01-18 16:37 UTC by Sebastian Dröge (slomo)
Modified: 2018-01-23 14:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
qtmux: Allow configuring trak timescale per pad/trak (6.53 KB, patch)
2018-01-18 16:37 UTC, Sebastian Dröge (slomo)
none Details | Review
qtmux: Allow configuring trak timescale per pad/trak (8.07 KB, patch)
2018-01-18 17:13 UTC, Sebastian Dröge (slomo)
committed Details | Review

Description Sebastian Dröge (slomo) 2018-01-18 16:37:28 UTC
See commit message
Comment 1 Sebastian Dröge (slomo) 2018-01-18 16:37:34 UTC
Created attachment 367025 [details] [review]
qtmux: Allow configuring trak timescale per pad/trak

It generally makes not much sense to configure it for all pads/traks at
once as this value is usually different for each of them. As such, add a
new property on the pads in addition to the existing property on the
whole muxer.
Comment 2 Tim-Philipp Müller 2018-01-18 16:53:37 UTC
Looks generally fine to me.

Perhaps add a gst_qt_mux_pad_has_timescale() and gst_qt_mux_pad_get_timescale() that also takes the pad's lock like in the object setter, and it would also make the code nicer to read.

Would also be nice if you added the new gtype thing to the pad template so that gst-inspect prints the properties.
Comment 3 Sebastian Dröge (slomo) 2018-01-18 17:13:35 UTC
Created attachment 367026 [details] [review]
qtmux: Allow configuring trak timescale per pad/trak

It generally makes not much sense to configure it for all pads/traks at
once as this value is usually different for each of them. As such, add a
new property on the pads in addition to the existing property on the
whole muxer.
Comment 4 Sebastian Dröge (slomo) 2018-01-23 14:14:16 UTC
Needs https://bugzilla.gnome.org/show_bug.cgi?id=792680 too and then I'll merge both
Comment 5 Sebastian Dröge (slomo) 2018-01-23 14:42:21 UTC
Attachment 367026 [details] pushed as c71cd08 - qtmux: Allow configuring trak timescale per pad/trak