GNOME Bugzilla – Bug 792649
qtmux: Allow configuring trak timescale per pad/trak
Last modified: 2018-01-23 14:46:21 UTC
See commit message
Created attachment 367025 [details] [review] qtmux: Allow configuring trak timescale per pad/trak It generally makes not much sense to configure it for all pads/traks at once as this value is usually different for each of them. As such, add a new property on the pads in addition to the existing property on the whole muxer.
Looks generally fine to me. Perhaps add a gst_qt_mux_pad_has_timescale() and gst_qt_mux_pad_get_timescale() that also takes the pad's lock like in the object setter, and it would also make the code nicer to read. Would also be nice if you added the new gtype thing to the pad template so that gst-inspect prints the properties.
Created attachment 367026 [details] [review] qtmux: Allow configuring trak timescale per pad/trak It generally makes not much sense to configure it for all pads/traks at once as this value is usually different for each of them. As such, add a new property on the pads in addition to the existing property on the whole muxer.
Needs https://bugzilla.gnome.org/show_bug.cgi?id=792680 too and then I'll merge both
Attachment 367026 [details] pushed as c71cd08 - qtmux: Allow configuring trak timescale per pad/trak