After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792634 - Expanded panel menus don't fade out cleanly on close
Expanded panel menus don't fade out cleanly on close
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
3.26.x
Other Linux
: Normal minor
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2018-01-18 08:26 UTC by Daniel van Vugt
Modified: 2018-08-28 06:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix-792634-v1.patch (1.17 KB, patch)
2018-01-18 09:03 UTC, Daniel van Vugt 		none Details | Review
fix-792634-v2.patch (1.20 KB, patch)
2018-01-22 04:49 UTC, Daniel van Vugt 		none Details | Review

Description Daniel van Vugt 2018-01-18 08:26:47 UTC 
Expanded panel menus don't fade out cleanly on close.

1. Open the panel menu and expand any one of the submenus.
2. Click on the desktop to close the panel menu.

Expected: Menu fades out cleanly like when it wasn't expanded.
Observed: Expanded part of the menu does not fade out cleanly.

I've stumbled on a fix for this so a patch will follow soon.
Comment 1 Daniel van Vugt 2018-01-18 09:03:07 UTC 
Created attachment 366995 [details] [review]
fix-792634-v1.patch

Here's a fix.

As an added bonus, gnome-shell's CPU usage is almost halved for the case of a menu left open over a busy desktop :)
Comment 2 Marco Trevisan (Treviño) 2018-01-19 16:57:50 UTC 
Review of attachment 366995 [details] [review]:

Looks good to me, works as expected even with themes using opacity.
Comment 3 Marco Trevisan (Treviño) 2018-01-19 16:58:59 UTC 
Review of attachment 366995 [details] [review]:

Ah, please get rid of the "More information" part from commit message, and add Bonus up in the commit text if you believe is the case.
Comment 4 Daniel van Vugt 2018-01-22 04:49:58 UTC 
Created attachment 367198 [details] [review]
fix-792634-v2.patch

Same patch, different comments.
Comment 5 Daniel van Vugt 2018-04-10 07:11:21 UTC 
The above patch has been superseded by:
https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/73
Comment 6 Daniel van Vugt 2018-08-28 06:57:32 UTC 
^^^
Fix committed to gnome-shell master now. Scheduled for release in gnome-shell 3.29.92.