After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792608 - Expose metered connection setting
Expose metered connection setting
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Network
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2018-01-17 14:41 UTC by Georges Basile Stavracas Neto
Modified: 2018-01-18 03:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
connection-editor: Expose metered connection switch (6.38 KB, patch)
2018-01-17 14:41 UTC, Georges Basile Stavracas Neto 		none Details | Review
connection-editor: Expose metered connection switch (6.45 KB, patch)
2018-01-17 19:43 UTC, Georges Basile Stavracas Neto 		committed Details | Review

Description Georges Basile Stavracas Neto 2018-01-17 14:41:27 UTC 
NetworkManager has that, and we should be able to set that property from Control Center.

See the patch below.
Comment 1 Georges Basile Stavracas Neto 2018-01-17 14:41:34 UTC 
Created attachment 366944 [details] [review]
connection-editor: Expose metered connection switch

NetworkManager supports marking a connection as metered, meaning
that connection is e.g. charged by its usage or extremely limited.
When a network is metered, background network usage must cease
and the behavior of the various OS pieces must be adjusted.

This patch adds a switch to set a connection as metered or not.
The property is imediately propagated to NetworkManager.
Comment 2 Nick Richards 2018-01-17 14:47:49 UTC 
This is also in the latest design from Allan, although the patch doesn't implement *all* of the design. ;-)
Comment 3 Georges Basile Stavracas Neto 2018-01-17 19:43:48 UTC 
Created attachment 366968 [details] [review]
connection-editor: Expose metered connection switch

Update comment with bug report.
Comment 4 Jonathan Kang 2018-01-18 02:35:37 UTC 
Review of attachment 366968 [details] [review]:

Looks good overall except the fact that after changing the value of "metered" and click "apply" button, I get the following error:

> (gnome-control-center:31910): -cc-panel-WARNING **: 10:26:42.619: Failed to commit changes: No such method 'Update2'
Comment 5 Georges Basile Stavracas Neto 2018-01-18 03:07:01 UTC 
As per IRC:

feaneron   i'll then proceed and push the patch. ok to you?
jkang      Sure. Looks pretty good

Attachment 366968 [details] pushed as a37d04d - connection-editor: Expose metered connection switch

Thanks for the review.