GNOME Bugzilla – Bug 792543
rtpbin: fix leak of elements requested by signals
Last modified: 2018-01-18 14:39:18 UTC
When the signal returns a floating reference, as its return type is transfer full, we need to sink it ourselves before passing it to gst_bin_add (which is transfer floating). This allows us to unref it in bin_remove_element later on, and thus to also release the reference we now own if the signal returns a non-floating reference as well. As we now still hold a reference to the element when removing it, we also need to lock its state and setting it to NULL before unreffing it
Created attachment 366857 [details] [review] rtpbin: fix leak of elements requested by signals
Same fix needed for all the GL elements that have a create-element signal
(In reply to Sebastian Dröge (slomo) from comment #2) > Same fix needed for all the GL elements that have a create-element signal See https://bugzilla.gnome.org/show_bug.cgi?id=792597
Attachment 366857 [details] pushed as 03dc229 - rtpbin: fix leak of elements requested by signals