GNOME Bugzilla – Bug 792533
UI: Align Custom command and When command exits
Last modified: 2021-06-10 21:20:56 UTC
Profile Prefs -> Commands The entry box of "Custom command" and the combo box of "When command exits" should have their left edges aligned. --- The .ui file is a real piece of beauty here :-D [...] <child> <object class="GtkVBox" id="vbox91"> <property name="visible">True</property> <property name="can_focus">False</property> <property name="border_width">12</property> <property name="spacing">18</property> <child> <object class="GtkVBox" id="vbox80"> <property name="visible">True</property> <property name="can_focus">False</property> <property name="spacing">6</property> <child> <object class="GtkVBox" id="vbox81"> <property name="visible">True</property> <property name="can_focus">False</property> <child> <object class="GtkVBox" id="vbox92"> <property name="visible">True</property> <property name="can_focus">False</property> <property name="spacing">6</property> <child> [...] Hopefully a single GtkGrid will do it.
Created attachment 366875 [details] [review] Fix With GtkGrid, there can no longer be a single widget for the custom command label and entry box, so their sensitivity cannot be toggled together. It doesn't seem to be a problem to bind both of them to the same gsettings key though. The lengths of the labels "Custom command" and "When command exits" in English happen to be so that with the logical indentation of "Custom command" instead it looks as if the two labels were centered rather than left aligned. Meh, probably not much we can do, other than dropping this patch and leaving the UI as-is. (Maybe my eyes only spotted this because yesterday I was testing Guake's GTK+-3 port where the labels are centered.) Expanding the combo box to the entire width also looks quite nice, worth a try (replace halign=start by hexpand=True). As usual, the XML is unindented for a nicer diff, will indent before submitting.
(In reply to Egmont Koblinger from comment #1) > it looks as if the two labels were centered There's probably not much point in indenting. "Use colors from system theme" also makes the options below insensitive, yet they are not indented. It's not confusing at all. Or, even simpler, in the spirit of "☑ Custom font: Mono blah" and "☑ Limit scrollback to: n lines" we could squeeze these two lines into one without loss of usability. Current: ☑ Run a custom command instead of my shell Custom command: _____ Proposed: ☑ Custom command: _____
When unchecked, the insensitive command field could show the user's shell, or some text like "Your default shell will be launched". Bug 706927 and bug 758812 are also relevant. IMHO let's do the alignment/indentation fix only for now, and the rest for 3-30.
Comment on attachment 366875 [details] [review] Fix (In reply to Egmont Koblinger from comment #3) > IMHO let's do the alignment/indentation fix only for now, and the rest for > 3-30. Agreed. Thanks!
(In reply to Egmont Koblinger from comment #3) > When unchecked, the insensitive command field could show the user's shell, > or some text like "Your default shell will be launched". We could use radio buttons: Launch: ( ) Shell: [Default v] [x] Login shell ( ) Custom command: [ ]
Comment on attachment 366875 [details] [review] Fix Submitted, with the indentation removed. Keeping the bug open for further improvements.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-terminal/-/issues/7806.