GNOME Bugzilla – Bug 792503
Compat tab warning / spacing
Last modified: 2018-01-13 23:45:14 UTC
Created attachment 366784 [details] [review] restore warning On Profile prefs -> Compatibility, the spacing at the top of the notebook page is about twice as big as on other tabs. This is because there's a zero-height text label there which (probably accidentally) got lost from the UI several years ago, but is still translatable/translated. Here's a patch to resurrect that text. Note that I don't understand what I'm doing with that max_width_chars=0, that's just how I managed to wrap the text. Shall we restore this warning, or drop for good? This is probably the only piece of italic text on the entire g-t UI. Keep it that way? In the mean time, there's a vbox containing three children: this label, the grid of 4 rows, and the reset button. I guess this could just be a single grid of 5-6 rows.
(In reply to Egmont Koblinger from comment #0) > Created attachment 366784 [details] [review] [review] > restore warning > > On Profile prefs -> Compatibility, the spacing at the top of the notebook > page is about twice as big as on other tabs. > > This is because there's a zero-height text label there which (probably > accidentally) got lost from the UI several years ago, but is still > translatable/translated. Seems this was due to a glade bug (commit d99a84c45fce74b8cf2be0eab86185c79ca5c4e5) and went unnoticed. > Here's a patch to resurrect that text. Note that I don't understand what I'm > doing with that max_width_chars=0, that's just how I managed to wrap the > text. > > Shall we restore this warning, or drop for good? Since it's been years with this gone without anyone missing it, we should drop it for good. > In the mean time, there's a vbox containing three children: this label, the > grid of 4 rows, and the reset button. I guess this could just be a single > grid of 5-6 rows. Yes.
Created attachment 366785 [details] [review] remove warning; convert to a single gtkgrid Note that the "Reset" button became closer to the Narrow/Wide row. Meh. I restore the bigger gap if you insist :)
Oh, and of course I'll fix the xml's indentation before submitting.
Comment on attachment 366785 [details] [review] remove warning; convert to a single gtkgrid > Note that the "Reset" button became closer to the Narrow/Wide row. Meh. I > restore the bigger gap if you insist :) I won't :-)