After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792370 - GNetworkMonitor: Rename "network-changed" signal argument
GNetworkMonitor: Rename "network-changed" signal argument
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2018-01-09 15:05 UTC by Bastien Nocera
Modified: 2018-01-09 16:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GNetworkMonitor: Rename "network-changed" signal argument (1.98 KB, patch)
2018-01-09 15:05 UTC, Bastien Nocera 		none Details | Review
GNetworkMonitor: Rename "network-changed" signal argument (2.00 KB, patch)
2018-01-09 15:24 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2018-01-09 15:05:37 UTC 
.
Comment 1 Bastien Nocera 2018-01-09 15:05:55 UTC 
Created attachment 366554 [details] [review]
GNetworkMonitor: Rename "network-changed" signal argument

Because the argument being called "available" and the property being
called "network-available" is confusing.
Comment 2 Philip Withnall 2018-01-09 15:13:29 UTC 
Review of attachment 366554 [details] [review]:

Sure.
Comment 3 Bastien Nocera 2018-01-09 15:24:11 UTC 
Created attachment 366556 [details] [review]
GNetworkMonitor: Rename "network-changed" signal argument

Because the argument being called "available" and the property being
called "network-available" is confusing.

Also remove the details of what that value means, as it's already
described in the property, and duplicating the explanation makes it look
like it might have a different meaning.
Comment 4 Philip Withnall 2018-01-09 15:45:28 UTC 
Review of attachment 366556 [details] [review]:

OK.
Comment 5 Philip Withnall 2018-01-09 16:25:11 UTC 
Pushed to master.

Attachment 366556 [details] pushed as 181d1c3 - GNetworkMonitor: Rename "network-changed" signal argument