After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792324 - gkeyfile: Document need for KEEP_TRANSLATIONS with get_locale_string()
gkeyfile: Document need for KEEP_TRANSLATIONS with get_locale_string()
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: docs
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2018-01-08 10:37 UTC by Philip Withnall
Modified: 2018-01-08 10:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gkeyfile: Document need for KEEP_TRANSLATIONS with get_locale_string() (1.97 KB, patch)
2018-01-08 10:37 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2018-01-08 10:37:02 UTC 
Trivial patch attached. I wanted some review on the wording.
Comment 1 Philip Withnall 2018-01-08 10:37:06 UTC 
Created attachment 366483 [details] [review]
gkeyfile: Document need for KEEP_TRANSLATIONS with get_locale_string()

When using g_key_file_get_locale_string() or get_locale_string_list(),
the GKeyFile must have been loaded with G_KEY_FILE_KEEP_TRANSLATIONS if
the lookup locale differs from the one which was current when the key
file was loaded.

Document that.

Signed-off-by: Philip Withnall <withnall@endlessm.com>
Comment 2 Emmanuele Bassi (:ebassi) 2018-01-08 10:38:38 UTC 
Review of attachment 366483 [details] [review]:

ACK-by: me
Comment 3 Philip Withnall 2018-01-08 10:56:14 UTC 
Attachment 366483 [details] pushed as 8f7cc8c - gkeyfile: Document need for KEEP_TRANSLATIONS with get_locale_string()