After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792279 - Use portable sed syntax in gdk/wayland/Makefile.am
Use portable sed syntax in gdk/wayland/Makefile.am
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Wayland
3.22.x
Other FreeBSD
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2018-01-06 18:59 UTC by Ting-Wei Lan
Modified: 2018-01-09 18:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
wayland: Use portable sed syntax in gdk/wayland/Makefile.am (1.12 KB, patch)
2018-01-06 19:01 UTC, Ting-Wei Lan 		committed Details | Review

Description Ting-Wei Lan 2018-01-06 18:59:56 UTC 
Wayland has been committed to FreeBSD ports for almost one year. Although there are still many downstream patches, I think we can start testing Wayland build on FreeBSD. It is still not enabled by default, so users who want to test it have to build Mesa and possibly other packages from sources themselves.

POSIX only supports basic regular expressions (BRE) in sed command. \<, \>, \+, \? are not available, which can cause build failure when Wayland backend is enabled because GNU make cannot find rules to build required *-protocol.c and *-protocol.h files.
Comment 1 Ting-Wei Lan 2018-01-06 19:01:24 UTC 
Created attachment 366428 [details] [review]
wayland: Use portable sed syntax in gdk/wayland/Makefile.am

Replace non-portable \<, \>, \+ with \(, \), \{, \} to avoid build
failure on systems not using GNU sed.
Comment 2 Matthias Clasen 2018-01-08 13:54:22 UTC 
Assuming you've tested it, sure!
Comment 3 Ting-Wei Lan 2018-01-09 18:48:26 UTC 
Attachment 366428 [details] pushed as b68e55e - wayland: Use portable sed syntax in gdk/wayland/Makefile.am