GNOME Bugzilla – Bug 792221
Port to g_auto*
Last modified: 2018-05-04 13:12:12 UTC
It would be nice if the code is ported to use g_auto* macros so that the allocated resource is automatically freed when out of scope. This shall help save many leaks in the application.
Created attachment 366345 [details] [review] main: Port to g_auto*
Created attachment 366346 [details] [review] application: Port to g_auto*
Created attachment 366347 [details] [review] app-menu: Port to g_auto*
Created attachment 366348 [details] [review] import-dialog: Port to g_auto*
Created attachment 366349 [details] [review] organize-dialog: Port to g_auto*
Created attachment 366351 [details] [review] note-view: Port to g_auto*
Review of attachment 366345 [details] [review]: Patch seems fine, although I didn't test it. My only concern are the commit messages, which doesn't describe what it actually does. Please elaborate a little bit, so we can push it to master. Thanks.
Review of attachment 366346 [details] [review]: Please improve the commit message. Thx.
Review of attachment 366347 [details] [review]: Please improve the commit message. Thx.
Review of attachment 366348 [details] [review]: Please improve the commit message. Thx.
Review of attachment 366349 [details] [review]: Please improve the commit message. Thx.
Review of attachment 366351 [details] [review]: Please improve the commit message. Thx.
(In reply to Isaque Galdino from comment #7) > Patch seems fine, although I didn't test it. > My only concern are the commit messages, which doesn't describe what it > actually does. I wrote the commit message based on bug 788174. Should we actually elaborate it? Every commit will be linking to this bugzilla item, which explains that using g_auto* will help us free the resource automatically, rather than doing it ourself.
Created attachment 366588 [details] [review] main: Use g_auto*
Created attachment 366589 [details] [review] application: Use g_auto*
Created attachment 366590 [details] [review] app-menu: Use g_auto*
Created attachment 366591 [details] [review] import-dialog: Use g_auto*
Created attachment 366592 [details] [review] organize-dialog: Use g_auto*
Created attachment 366593 [details] [review] note-view: Use g_auto*
Review of attachment 366588 [details] [review]: Cool, please commit.
Review of attachment 366589 [details] [review]: Good, please commit.
Review of attachment 366590 [details] [review]: Good, please commit.
Review of attachment 366591 [details] [review]: Also good, please commit.
Review of attachment 366592 [details] [review]: Good, please commit.
Review of attachment 366593 [details] [review]: Thanks for your patches, please commit!
Review of attachment 366588 [details] [review]: Pushed to master.
Review of attachment 366589 [details] [review]: Pushed to master.
Review of attachment 366590 [details] [review]: Pushed to master.
Review of attachment 366591 [details] [review]: Pushed to master.
Review of attachment 366591 [details] [review]: Fixed status.
Review of attachment 366592 [details] [review]: Pushed to master.
Review of attachment 366593 [details] [review]: Pushed to master.
Created attachment 371005 [details] [review] webkit-editor: Use g_auto*
Review of attachment 371005 [details] [review]: Cool. Thx.
Attachment 371005 [details] pushed as 8fe5166 - webkit-editor: Use g_auto*
git-bz did that. Sorry, not yet ready for close.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-notes/issues/85.