After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 792194 - main-toolbar: Port to GtkBuilder xml
main-toolbar: Port to GtkBuilder xml
Status: RESOLVED FIXED
Product: bijiben
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Bijiben maintainer(s)
Bijiben maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2018-01-04 10:36 UTC by Mohammed Sadiq
Modified: 2018-01-14 21:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
main-toolbar: Port to GtkBuilder xml (47.67 KB, patch)
2018-01-04 10:37 UTC, Mohammed Sadiq 		committed Details | Review

Description Mohammed Sadiq 2018-01-04 10:36:09 UTC 
.
Comment 1 Mohammed Sadiq 2018-01-04 10:37:07 UTC 
Created attachment 366273 [details] [review]
main-toolbar: Port to GtkBuilder xml

Using GtkBuilder xml files for UI separates UI from program
logic. This helps simplify maitaining the code.
Comment 2 Isaque Galdino 2018-01-10 02:55:08 UTC 
Review of attachment 366273 [details] [review]:

The code seems fine, but as you mentioned that it was crashing, I decided to test it a little bit longer.
I'm running it on my box, so let's give it a couple days before we push it to master.

Thanks.
Comment 3 Mohammed Sadiq 2018-01-10 03:02:26 UTC 
(In reply to Isaque Galdino from comment #2)
> Review of attachment 366273 [details] [review] [review]:
> 
> The code seems fine, but as you mentioned that it was crashing, I decided to
> test it a little bit longer.
> I'm running it on my box, so let's give it a couple days before we push it
> to master.

Sure. more testing is always good. Anyway, this patch shouldn't crash. I have fixed it before upload.

> 
> Thanks.
Comment 4 Isaque Galdino 2018-01-14 18:46:04 UTC 
Review of attachment 366273 [details] [review]:

So far, so good. Please push it to master. Thanks.
Comment 5 Isaque Galdino 2018-01-14 21:24:42 UTC 
Review of attachment 366273 [details] [review]:

Pushed to master.
Comment 6 Isaque Galdino 2018-01-14 21:25:15 UTC 
Thanks for your patch.