After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791906 - GSocketListenerClass.event has wrong signature
GSocketListenerClass.event has wrong signature
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2017-12-24 02:49 UTC by Christian Hergert
Modified: 2017-12-25 08:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix signature of event vfunc (1.12 KB, patch)
2017-12-24 02:53 UTC, Christian Hergert 		committed Details | Review

Description Christian Hergert 2017-12-24 02:49:08 UTC 
The signature for GSocketListener::event is:

 (GSocketListener *self,
  GSocketListenerEvent event,
  GSocket *socket)

However, the vfunc slot provided in the signal registration is:

 (GSocketListener *self,
  GSocketListenerEvent *event, <-- notice pointer
  GSocket *socket)

That prevents using the event vfunc correctly from subclasses of GSocketService.
Comment 1 Christian Hergert 2017-12-24 02:53:12 UTC 
Created attachment 365915 [details] [review]
fix signature of event vfunc
Comment 2 Philip Withnall 2017-12-24 14:10:38 UTC 
Review of attachment 365915 [details] [review]:

Yes please. Also backport it to glib-2-54.
Comment 3 Christian Hergert 2017-12-25 08:13:45 UTC 
Pushed to master and glib-2-54.