After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791730 - Crashes when g_tls_client_connection_openssl_initable_init is called multiple times
Crashes when g_tls_client_connection_openssl_initable_init is called multiple...
Status: RESOLVED FIXED
Product: glib-openssl
Classification: Other
Component: general
2.50.x
Other Linux
: Normal normal
: ---
Assigned To: glib-openssl Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-12-18 11:15 UTC by public
Modified: 2017-12-19 10:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Only initialize data_index once. (958 bytes, patch)
2017-12-18 11:15 UTC, public 		none Details | Review
Git format patch (1.50 KB, patch)
2017-12-19 10:21 UTC, public 		committed Details | Review

Description public 2017-12-18 11:15:00 UTC 
Created attachment 365690 [details] [review]
Only initialize data_index once.

g_tls_client_connection_openssl_initable_init will reset the global data_index variable. If it is called multiple times it can cause a crash in retrieve_certificate where it uses the index to retrieve stored data.

The attached patch makes it only initialize data_index once.
Comment 1 Ignacio Casal Quinteiro (nacho) 2017-12-18 11:37:15 UTC 
The patch looks good to me. Can you please attach instead a git format-patch so we give you the proper credit for it?
Comment 2 public 2017-12-19 10:21:01 UTC 
Created attachment 365738 [details] [review]
Git format patch