GNOME Bugzilla – Bug 791680
Fix out-of-source-dir building
Last modified: 2017-12-17 10:44:34 UTC
Add vapidir with absolute folder-path to just built latexila.vapi
Created attachment 365618 [details] [review] Fix out-of-source-dir building Add vapidir with absolute folder-path to just built latexila.vapi
Review of attachment 365618 [details] [review]: . ::: src/Makefile.am @@ +15,3 @@ --target-glib=2.50 \ --vapidir liblatexila \ + --vapidir $(abs_builddir)/liblatexila \ Why $(abs_builddir) is needed and not just $(builddir)? I think you can replace: --vapidir liblatexila with: --vapidir $(builddir)/liblatexila and it'll work for both builddir == srcdir builds and builddir != srcdir.
> Why $(abs_builddir) is needed and not just $(builddir)? $(builddir) doesn't work as one would expect. > I think you can replace: > --vapidir liblatexila > with: > --vapidir $(builddir)/liblatexila > and it'll work for both builddir == srcdir builds and builddir != srcdir. I would assume this can cause trouble if you ship the generated c-sources/files.
OK, I've pushed the commit: commit 7b5dacb591dc804e54d5b2142921e23e88b9e084 `make distcheck` still succeeds, and building with builddir == srcdir still works fine. Thanks for your patch!