After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791680 - Fix out-of-source-dir building
Fix out-of-source-dir building
Status: RESOLVED FIXED
Product: gnome-latex
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: unspecified
Assigned To: LaTeXila maintainer(s)
LaTeXila maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-12-16 12:03 UTC by Rico Tzschichholz
Modified: 2017-12-17 10:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix out-of-source-dir building (754 bytes, patch)
2017-12-16 12:04 UTC, Rico Tzschichholz
reviewed Details | Review

Description Rico Tzschichholz 2017-12-16 12:03:57 UTC
Add vapidir with absolute folder-path to just built latexila.vapi
Comment 1 Rico Tzschichholz 2017-12-16 12:04:00 UTC
Created attachment 365618 [details] [review]
Fix out-of-source-dir building

Add vapidir with absolute folder-path to just built latexila.vapi
Comment 2 Sébastien Wilmet 2017-12-16 13:15:59 UTC
Review of attachment 365618 [details] [review]:

.

::: src/Makefile.am
@@ +15,3 @@
 	--target-glib=2.50	\
 	--vapidir liblatexila	\
+	--vapidir $(abs_builddir)/liblatexila	\

Why $(abs_builddir) is needed and not just $(builddir)?

I think you can replace:
--vapidir liblatexila
with:
--vapidir $(builddir)/liblatexila
and it'll work for both builddir == srcdir builds and builddir != srcdir.
Comment 3 Rico Tzschichholz 2017-12-16 17:09:19 UTC
> Why $(abs_builddir) is needed and not just $(builddir)?

$(builddir) doesn't work as one would expect.

> I think you can replace:
> --vapidir liblatexila
> with:
> --vapidir $(builddir)/liblatexila
> and it'll work for both builddir == srcdir builds and builddir != srcdir.

I would assume this can cause trouble if you ship the generated c-sources/files.
Comment 4 Sébastien Wilmet 2017-12-17 10:44:34 UTC
OK, I've pushed the commit:
commit 7b5dacb591dc804e54d5b2142921e23e88b9e084

`make distcheck` still succeeds, and building with builddir == srcdir still works fine.

Thanks for your patch!