GNOME Bugzilla – Bug 79147
Loses icon changes for mime types
Last modified: 2009-08-15 18:40:50 UTC
Do this: 1) run gnome2-file-types-properties 2) Select Documents->Published Materials->PDF Document and choose Edit. 3) Change the filetype icon to something else, like the RichText icon. 4) Click OK, then Apply on the parent dialog and Close. 5) Run gnome2-file-types-properties again Now, here I see that Application/PDF has disappeared from Documents/Published Materials -category, and there is a new category called "ocuments/Published Materials/" where it is. It does not have the icon I defined though, and I never changed the category myself. If I open it again, and correct the category, and OK->Apply->Close it gets fixed. But I still cannot set a custom icon for it. If I try to do that, it goes to "ocuments" category again. Also, it looks like I always need to "Apply" on the gnome2-file-types-properties window when I make changes, just clicking "Close" seems to discard them. This sounds weird. Just for the record, this is a pretty recent gnome-control-center from CVS, on Debian unstable in PPC hardware.
Tig: Jody says a patch that would affect this was checked in this morning. Can you update tomorrow and see if you're still seeing this?
Yeah. still borks.
I have a patch that fixes the icon changing, you can select a custom icon and it works. But you still have to hit the apply button. I'll work on that this evening.
well i just did the fix, it was a matter of writing a line. Now i have a question, the apply button on the dialog doesn't make any sense (i think) should i go ahead and remove it?
The real problem appears to have been in gnome-vfs. The mime editor was saving an absolute path to the new icon. gnome-vfs was assuming that the path must be relative, and ignored it. Diego, I think we need the apply button, the order is obviously non-hig compliant. However, the blessed solution eludes me. Do we want to 1) Make the dialog instant apply ? 2) rename & reorder the buttons -> Cancel Apply
cc'd nils and seth to answer the HIG button order question.
(1), make the dialogue instant apply, is the preferred solution.
seth : too slow, I already did that a few days a go.
kick ass