After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791460 - meson: fixes for OSX
meson: fixes for OSX
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: osx
unspecified
Other Mac OS
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2017-12-11 01:47 UTC by Håvard Graff (hgr)
Modified: 2018-01-04 21:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.06 KB, patch)
2017-12-11 01:47 UTC, Håvard Graff (hgr) 		none Details | Review
patch (714 bytes, patch)
2017-12-11 01:48 UTC, Håvard Graff (hgr) 		committed Details | Review
patch (1.95 KB, patch)
2017-12-11 01:48 UTC, Håvard Graff (hgr) 		none Details | Review
updated patch (1.94 KB, patch)
2017-12-11 03:35 UTC, Håvard Graff (hgr) 		committed Details | Review
updated patch (1.19 KB, patch)
2017-12-11 03:51 UTC, Håvard Graff (hgr) 		committed Details | Review

Description Håvard Graff (hgr) 2017-12-11 01:47:30 UTC 
Created attachment 365336 [details] [review]
patch

Some patches to make glib build with meson on OSX
Comment 1 Håvard Graff (hgr) 2017-12-11 01:48:04 UTC 
Created attachment 365337 [details] [review]
patch
Comment 2 Håvard Graff (hgr) 2017-12-11 01:48:26 UTC 
Created attachment 365338 [details] [review]
patch
Comment 3 Håvard Graff (hgr) 2017-12-11 03:35:48 UTC 
Created attachment 365340 [details] [review]
updated patch
Comment 4 Håvard Graff (hgr) 2017-12-11 03:51:02 UTC 
Created attachment 365341 [details] [review]
updated patch
Comment 5 Nirbheek Chauhan 2017-12-11 11:24:40 UTC 
Review of attachment 365337 [details] [review]:

LGTM
Comment 6 Nirbheek Chauhan 2017-12-11 11:25:19 UTC 
Review of attachment 365340 [details] [review]:

LGTM
Comment 7 Nirbheek Chauhan 2017-12-11 11:29:57 UTC 
Review of attachment 365341 [details] [review]:

::: gio/meson.build
@@ +19,3 @@
   # they aren't present at run-time (on Windows 2000).
   gnetworking_h_wspiapi_include = '#include <wspiapi.h>'
+elif not host_system.contains('android')

I think this needs a comment explaining what exactly this check is doing. It obviously confused someone before when porting from autotools to meson, and it will happen again :)
Comment 8 Nirbheek Chauhan 2017-12-14 10:52:34 UTC 
I edited the comment right before the C_IN patch, all pushed.
Comment 9 Xavier Claessens 2018-01-04 21:00:34 UTC 
While working on adding those flags into glib and gio pc files, I noticed that configure.ac add them into LDFLAGS which means everything gets built with those flags and not only libglib, as far as I understand. The corresponding in meson world is add_project_link_arguments().

I changed that in attachment #366328 [details] on bug #788773. Please comment there if I'm wrong.