GNOME Bugzilla – Bug 791374
kmssink: fix kmssink fail to start when not connect display
Last modified: 2018-11-03 14:16:20 UTC
Currently kmssink will fail when not connect display to device. Get display connected status from drm connector, drop all buffer when display not connected to make pipeline can run.
Created attachment 365228 [details] [review] kmssink: fix kmssink fail to start when not connect display Get display connected status from drm connector, drop all buffer when display not connected
Review of attachment 365228 [details] [review]: Am I right to think that if the display get connected later, nothing happens ?
(In reply to Nicolas Dufresne (stormer) from comment #2) > Review of attachment 365228 [details] [review] [review]: > > Am I right to think that if the display get connected later, nothing happens > ? It seems so. Because self->display_connected is only TRUE at _start(), which is called when the sink changes from NULL to READY state. So, what's the purpose of this patch? keep the pipeline working even if nothing is displayed? why?
(In reply to Nicolas Dufresne (stormer) from comment #2) > Review of attachment 365228 [details] [review] [review]: > > Am I right to think that if the display get connected later, nothing happens > ? Temporary, nothing happened, if so, we need add reset() to get display parameters when display connection status changed. This patch can only make pipeline working for audio chain.
Ok, I'd say this patch is incomplete then. In this form it's not useful. Your app could use fakesink and have some code that detect the display connection.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/639.