GNOME Bugzilla – Bug 791318
GBytes: Improve documentation
Last modified: 2017-12-07 10:31:49 UTC
Created attachment 365148 [details] [review] GBytes: Improve documentation Improve documentation
Review of attachment 365148 [details] [review]: The commit message could be more descriptive: how is the documentation being improved? I suggest something like: “gbytes: Clarify nullability for g_bytes_unref() in docs” ::: glib/gbytes.c @@ +296,3 @@ * Releases a reference on @bytes. This may result in the bytes being + * freed. If bytes is NULL it simply returns, so there is no need to check + * against NULL before calling this function. There’s no need to make the same point twice here. You could simplify the addition to “If @bytes is %NULL, it will return immediately.”.
Created attachment 365182 [details] [review] gbytes: Clarify nullability for g_bytes_unref () in docs
Thanks. I tweaked the patch slightly before pushing, to add some missing gtk-doc syntax which got lost between my suggestion and the uploaded patch.