After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791296 - gtester-report: fix range usage when running as python3 app
gtester-report: fix range usage when running as python3 app
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2017-12-06 08:01 UTC by Dominique Leuenberger
Modified: 2017-12-06 10:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtester-report: fix range usage when running as python3 app (1.11 KB, patch)
2017-12-06 08:01 UTC, Dominique Leuenberger 		committed Details | Review

Description Dominique Leuenberger 2017-12-06 08:01:22 UTC 
gtester-report fails with

[ 3157s]   File "/usr/bin/gtester-report", line 78, in html_indent_string
[ 3157s]     for i in range (0, (n + 1) / 2):
[ 3157s] TypeError: 'float' object cannot be interpreted as an integer

othrewise
Comment 1 Dominique Leuenberger 2017-12-06 08:01:27 UTC 
Created attachment 365092 [details] [review]
gtester-report: fix range usage when running as python3 app

When using python3 as interpreter, range only takes integer arguments or
it results in errors like:

+ Trace 238229

  • File "/usr/bin/gtester-report", line 78 in html_indent_string 
    for i in range (0, (n + 1) / 2):  TypeError: 'float' object cannot be interpreted as an integer






Comment 2


Philip Withnall





          2017-12-06 10:06:49 UTC
        



Review of attachment 365092 [details] [review]:

Looks good, thanks. Verified as working on Python 2 and 3.






Comment 3


Philip Withnall





          2017-12-06 10:07:47 UTC
        



Attachment 365092 [details] pushed as 1a07e35 - gtester-report: fix range usage when running as python3 app






Comment 4


Philip Withnall





          2017-12-06 10:09:45 UTC
        



Pushed to glib-2-54 too:

a434d020b (HEAD -> glib-2-54, origin/glib-2-54) gtester-report: fix range usage when running as python3 app