GNOME Bugzilla – Bug 791200
nmcli previous password is shown if you press up arrow key on password reprompt
Last modified: 2017-12-18 13:52:20 UTC
When nmcli reprompts to input your password, if you press up arrow key the previous password is shown. How to reproduce https://asciinema.org/a/150932
Created attachment 365593 [details] [PATCH 1/3] clients/cli: don't store a password in history
Created attachment 365594 [details] [PATCH 2/3] libnm-core: move detection of UTF-8 capable terminals to clients/
Created attachment 365595 [details] [PATCH 3/3] clients/cli: use a nicer password prompt
Thanks for the report. Fix ready for review, with some extra eye-candy.
Created attachment 365596 [details] [PATCH 3/3] clients/cli: use a nicer password prompt
Created attachment 365597 [details] [PATCH 3/3] clients/cli: use a nicer password prompt
(In reply to Lubomir Rintel from comment #4) > Thanks for the report. > > Fix ready for review, with some extra eye-candy. You're welcome. Thanks for the fix!
> libnm-core: move detection of UTF-8 capable terminals to clients/ nmt-connect-connection-list.c needs to include nm-client-utils.h > clients/cli: use a nicer password prompt +static void +nmc_secret_redisplay () Needs a 'void' argument, otherwise: clients/cli/common.c:883:1: error: function declaration isn’t a prototype [-Werror=strict-prototypes]
This just avoids awkwars surprises, ^^^^^^^ + what bg said. rest lgtm
This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.