After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791159 - validate: Use a single TCPServer for subprocess communication
validate: Use a single TCPServer for subprocess communication
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-devtools
unspecified
Other All
: Normal normal
: 1.13.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2017-12-03 10:47 UTC by Edward Hervey
Modified: 2017-12-03 11:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
validate: Use a single TCPServer for subprocess communication (7.93 KB, patch)
2017-12-03 10:47 UTC, Edward Hervey
committed Details | Review

Description Edward Hervey 2017-12-03 10:47:46 UTC
See patch
Comment 1 Edward Hervey 2017-12-03 10:47:49 UTC
Created attachment 364848 [details] [review]
validate: Use a single TCPServer for subprocess communication

Instead of creating a separate TCPServer for each test, just create
one which handles all connections in a threaded fashion.

Shaves off ~500ms per test
Comment 2 Thibault Saunier 2017-12-03 11:13:38 UTC
Review of attachment 364848 [details] [review]:

Looks good :-)

::: validate/launcher/baseclasses.py
@@ +551,3 @@
+                        break
+                if test is None:
+                    print("COULD NOT FIND TEST FOR UUID %s" % uuid)

Use Loggable.error?

@@ +1553,3 @@
+        self.server.serve_forever(poll_interval=0.05)
+
+

1  ligne :-)

@@ +1563,3 @@
+        os.environ["GST_VALIDATE_SERVER"] = "tcp://localhost:%s" % self.serverport
+
+

Same.
Comment 3 Edward Hervey 2017-12-03 11:26:21 UTC
Thanks ! Pushed with fixes:

commit 92285ef261639dbf25459bd21ea1fbb51a128616
Author: Edward Hervey <edward@centricular.com>
Date:   Sun Dec 3 10:42:49 2017 +0100

    validate: Use a single TCPServer for subprocess communication
    
    Instead of creating a separate TCPServer for each test, just create
    one which handles all connections in a threaded fashion.
    
    Shaves off ~500ms per test
    
    https://bugzilla.gnome.org/show_bug.cgi?id=791159