GNOME Bugzilla – Bug 791159
validate: Use a single TCPServer for subprocess communication
Last modified: 2017-12-03 11:26:38 UTC
See patch
Created attachment 364848 [details] [review] validate: Use a single TCPServer for subprocess communication Instead of creating a separate TCPServer for each test, just create one which handles all connections in a threaded fashion. Shaves off ~500ms per test
Review of attachment 364848 [details] [review]: Looks good :-) ::: validate/launcher/baseclasses.py @@ +551,3 @@ + break + if test is None: + print("COULD NOT FIND TEST FOR UUID %s" % uuid) Use Loggable.error? @@ +1553,3 @@ + self.server.serve_forever(poll_interval=0.05) + + 1 ligne :-) @@ +1563,3 @@ + os.environ["GST_VALIDATE_SERVER"] = "tcp://localhost:%s" % self.serverport + + Same.
Thanks ! Pushed with fixes: commit 92285ef261639dbf25459bd21ea1fbb51a128616 Author: Edward Hervey <edward@centricular.com> Date: Sun Dec 3 10:42:49 2017 +0100 validate: Use a single TCPServer for subprocess communication Instead of creating a separate TCPServer for each test, just create one which handles all connections in a threaded fashion. Shaves off ~500ms per test https://bugzilla.gnome.org/show_bug.cgi?id=791159