GNOME Bugzilla – Bug 791093
add OMX_PERFORMANCE debug category
Last modified: 2018-01-29 17:17:28 UTC
.
Created attachment 364765 [details] [review] add OMX_PERFORMANCE debug category Can be used to log buffers exchange between OMX and gst-omx to profile performances of the OMX component. Ideally this should be done using tracer hooks but it's currently not possible to define custom hooks outside of core. Use GST_DEBUG="OMX_PERFORMANCE:8" to enable it. See also https://github.com/gdesmott/gst-log-parser/blob/master/src/bin/omx-perf.rs as a simple program consuming those logs to generate gnuplot files and stats.
Review of attachment 364765 [details] [review]: What's the use for this if you cannot match the buffers ? Should't you print the buffer pointer, or some ID / Handle ?
Can't you easily get this info from the existing debug log output by matching function names?
If so, that commit message should say something since it's not trivial.
(In reply to Tim-Philipp Müller from comment #3) > Can't you easily get this info from the existing debug log output by > matching function names? Kind of, but not for all events. My goal here was to provide an experience very similar to the hooks/tracer system. Having a specific debug domain make it easier to turn on/off and allow us to enable only those logs (which can be useful to reduce the logs overhead when profiling performances). I also wanted to make those more parser than human reader friendly. My vague plan was to use serialized GstStructure if I ever need to pass more infos (like tracers do). (In reply to Nicolas Dufresne (stormer) from comment #2) > Review of attachment 364765 [details] [review] [review]: > > What's the use for this if you cannot match the buffers ? Should't you print > the buffer pointer, or some ID / Handle ? We were only interested in the events rate and timing but indeed that could be useful. I'll add that using the parser friendly syntax suggested above.
Created attachment 367578 [details] [review] add OMX_PERFORMANCE debug category Can be used to log buffers exchange between OMX and gst-omx to profile performances of the OMX component. Ideally this should be done using tracer hooks but it's currently not possible to define custom hooks outside of core. Use GST_DEBUG="OMX_PERFORMANCE:8" to enable it. See also https://github.com/gdesmott/gst-log-parser/blob/master/src/bin/omx-perf.rs as a simple program consuming those logs to generate gnuplot files and stats.
Review of attachment 367578 [details] [review]: Yep, likes it.
Attachment 367578 [details] pushed as 65cc312 - add OMX_PERFORMANCE debug category