After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 791036 - Guard for g_output_stream_vprintf makes no sense
Guard for g_output_stream_vprintf makes no sense
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
unspecified
Other Linux
: Normal critical
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2017-11-30 17:59 UTC by Izak van Langevelde
Modified: 2017-12-01 10:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
goutputstream: Fix pre-condition (1018 bytes, patch)
2017-12-01 10:03 UTC, Philip Withnall 		committed Details | Review

Description Izak van Langevelde 2017-11-30 17:59:39 UTC 
Function g_output_stream_vprintf has guard

g_return_val_if_fail (cancellable == NULL || G_IS_CANCELLABLE (stream), FALSE);

I believe what is meant is

g_return_val_if_fail (cancellable == NULL || G_IS_CANCELLABLE (cancellable), FALSE);
Comment 1 Philip Withnall 2017-12-01 10:03:16 UTC 
Well, spotted, thanks. Fixed on master and glib-2-54.

The following fix has been pushed:
36f7440 goutputstream: Fix pre-condition
Comment 2 Philip Withnall 2017-12-01 10:03:26 UTC 
Created attachment 364724 [details] [review]
goutputstream: Fix pre-condition

Spotted by Izak van Langevelde.

Signed-off-by: Philip Withnall <withnall@endlessm.com>